feat: specify no-trunc for full snapshot ID #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
specify-image-history-no-trunc-for-full-snapshot-id
branch
from
d970c23 to
a889e39
Compare
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
specify-image-history-no-trunc-for-full-snapshot-id
branch
from
a889e39 to
1fb9890
Compare
coderbirju
approved these changes
Dec 27, 2024
austinvazquez
deleted the
specify-image-history-no-trunc-for-full-snapshot-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#200
Description of changes:
This change adds --no-trunc option for image history tests which expect the full sha256 snapshot ID. Starting in nerdctl 2.0, image history command not specified with no truncation option will display a shorter snapshot ID. This test should continue to work against older Finch versions which have support for --no-trunc option.
Testing done:
Ran test in runfinch/finch-core#472
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.