test: Add an e2e test for the COMPOSE_FILE environment variable in fi… #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nch compose command The following pull request attempts to modify finch compose command to allow the COMPOSE_FILE environment variable. - runfinch/finch#994 Therefore, this fix adds an e2e test to run finch compose command with the COMPOSE_FILE environment variable. Signed-off-by: Hayato Kiwata <[email protected]>
1 task
pendo324
reviewed
Jun 24, 2024
…nch compose command Based on the review, the UpdateEnv function has been modified to pass the environment variable key and value as arguments. Also, the DeleteEnv function has been modified to accept environment variable key. Signed-off-by: Hayato Kiwata <[email protected]>
|
Thanks for review!!!, @pendo324 I have fixed based on the review, so could you please re-review when you have time ??? |
|
Next step is to create a new release of common-tests and bump the version in finch/finch-core. I can take care of that 👍 |
|
Thank you !!! Also, sorry, I assigned the following PR . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nch compose command
The following pull request attempts to modify finch compose command to allow the COMPOSE_FILE environment variable.
Therefore, this fix adds an e2e test to run finch compose command with the COMPOSE_FILE environment variable.
Issue #, if available: N/A
Description of changes: The details are described in this commit message.
Testing done: Yes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.