Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retry image pull for 3 times and then fail #137

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Shubhranshu153
Copy link
Contributor

Issue #, if available:

Description of changes:
Seems the ecr connection is reset during runtime which restricts any chance for successful pull for open connections. Adding retry to see if that can solve the issue. A more broad approach can to retry the entire process.

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Shubhranshu153 Shubhranshu153 requested a review from pendo324 March 26, 2024 23:14
@Shubhranshu153 Shubhranshu153 merged commit 3f4765f into runfinch:main Mar 27, 2024
3 checks passed
Shubhranshu153 pushed a commit that referenced this pull request Mar 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.7.19](v0.7.18...v0.7.19)
(2024-03-27)


### Bug Fixes

* Retry image pull for 3 times and then fail
([#137](#137))
([3f4765f](3f4765f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants