fix: use of uninitialized global variable #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <[email protected]>
pendo324
changed the title
Shubhranshu153
approved these changes
Mar 26, 2024
pendo324
pushed a commit
that referenced
this pull request
Mar 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.18](v0.7.17...v0.7.18) (2024-03-26) ### Bug Fixes * use of uninitialized global variable ([#135](#135)) ([02a134d](02a134d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Shubhranshu153
pushed a commit
to Shubhranshu153/common-tests
that referenced
this pull request
Mar 26, 2024
Issue #, if available: https://github.com/runfinch/finch/actions/runs/8427176493/job/23080891806#step:10:2784 *Description of changes:* - Fixes issue where some tests were using an uninitialized global variable since the assignment statements were executed before ginkgo's `SynchronizedBeforeSuite`, which actually populates `localImages` - Somehow I didn't catch this when I did my local testing before the last release, but I have confirmed this change fixes it locally - Also added a trivial change to allow remote pulls in `SetupLocalRegistry` to take up to 60 seconds *Testing done:* - Local testing - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]>
Shubhranshu153
pushed a commit
to Shubhranshu153/common-tests
that referenced
this pull request
Mar 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.18](runfinch/common-tests@v0.7.17...v0.7.18) (2024-03-26) ### Bug Fixes * use of uninitialized global variable ([runfinch#135](runfinch#135)) ([02a134d](runfinch@02a134d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: https://github.com/runfinch/finch/actions/runs/8427176493/job/23080891806#step:10:2784
Description of changes:
SynchronizedBeforeSuite, which actually populateslocalImagesSetupLocalRegistryto take up to 60 secondsTesting done:
Local testing
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.