perf: pre-fetch all images before running tests #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <[email protected]>
Shubhranshu153
approved these changes
Mar 22, 2024
|
Working on fixing the linting errors |
Signed-off-by: Justin Alvarez <[email protected]>
Shubhranshu153
pushed a commit
to Shubhranshu153/common-tests
that referenced
this pull request
Mar 26, 2024
Issue #, if available: *Description of changes:* - Pre-fetches all images before running tests - The bulk of the change is in [`tests/tests.go`](https://github.com/runfinch/common-tests/compare/main...pendo324:common-tests:pre-fetch-images?expand=1#diff-a61afa8338f0442d1308258f7320c1a4a4698b432ac42d23bca256980f16f75a) - This drastically reduces the possibility of tests timing out due to external network download speed There might be a better way to implement this, this was just the first way I thought of. Please post suggestions if you have any *Testing done:* - Tested locally against latest Finch main branch - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
tests/tests.goThere might be a better way to implement this, this was just the first way I thought of. Please post suggestions if you have any
Testing done:
Tested locally against latest Finch main branch
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.