fix: use new values of session #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <[email protected]>
Shubhranshu153
approved these changes
Feb 27, 2024
pendo324
pushed a commit
that referenced
this pull request
Feb 27, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.14](v0.7.13...v0.7.14) (2024-02-27) ### Bug Fixes * use new values of session ([#121](#121)) ([a09ae51](a09ae51)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: https://github.com/runfinch/finch/actions/runs/8028176583/job/22044404059?pr=830
Description of changes:
Previously, the polling solution would just re-poll with the same string it got from the initial
session.Out.Contents(), so polling was not really doing anything.Now, every time it polls, a new value is used.
Testing done:
Tested locally
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.