Skip to content

Commit

Permalink
chore: sync release-please config with finch repo, pin actions (#108)
Browse files Browse the repository at this point in the history
Issue #, if available: Release please created "duplicate" PRs:
#104 and
#107. This is because of
the update to major version 4. We saw similar issues in the main finch
repo (see runfinch/finch#746), so this is just
porting over those changes.

*Description of changes:*
- Update release-please config
- pin actions to SHAs

*Testing done:*

- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Justin Alvarez <[email protected]>
  • Loading branch information
pendo324 authored Jan 5, 2024
1 parent 4c8befc commit 80f6989
Show file tree
Hide file tree
Showing 5 changed files with 68 additions and 38 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ jobs:
go-linter:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
with:
go-version-file: go.mod
cache: true
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
with:
# Pin the version in case all the builds start to fail at the same time.
# There may not be an automatic way (e.g., dependabot) to update a specific parameter of a Github Action,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-pr-title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ jobs:
name: conventional-commit
runs-on: ubuntu-latest
steps:
- uses: amannn/action-semantic-pull-request@v5
- uses: amannn/action-semantic-pull-request@e9fabac35e210fea40ca5b14c0da95a099eff26f # v5.4.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
35 changes: 1 addition & 34 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,37 +7,4 @@ jobs:
release-please:
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v4
with:
release-type: go
package-name: finch
# Include 'build' in the changelog and
# make it a releasable unit (patch version bump) because dependabot PRs uses it.
# For more details, see ../dependabot.yml.
#
# The mapping from type to section comes from conventional-commit-types [1]
# which is used by action-semantic-pull-request [2],
# which is used by us.
#
# [1] https://github.com/commitizen/conventional-commit-types/blob/master/index.json
# [2] https://github.com/amannn/action-semantic-pull-request/blob/0b14f54ac155d88e12522156e52cb6e397745cfd/README.md?plain=1#L60
changelog-types: >
[
{
"type":"feat",
"section":"Features",
"hidden":false
},
{
"type":"fix",
"section":"Bug Fixes",
"hidden":false
},
{
"type":"build",
"section":"Build System or External Dependencies",
"hidden":false
}
]
# Before we are at v1.0.0
bump-minor-pre-major: true
- uses: google-github-actions/release-please-action@cc61a07e2da466bebbc19b3a7dd01d6aecb20d1e # v4.0.2
3 changes: 3 additions & 0 deletions .release-please-manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
".": "0.7.9"
}
60 changes: 60 additions & 0 deletions release-please-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
{
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
"release-type": "go",
"bump-minor-pre-major": true,
"changelog-sections": [
{
"type": "build",
"section": "Build System or External Dependencies",
"hidden": false
},
{
"type": "exp",
"section": "Experimental",
"hidden": false
},
{
"type": "feat",
"section": "Features",
"hidden": false
},
{
"type": "fix",
"section": "Bug Fixes",
"hidden": false
},
{
"type": "revert",
"section": "Reverts",
"hidden": false
},
{
"type": "chore",
"section": "Miscellaneous Chores",
"hidden": true
},
{
"type": "docs",
"section": "Documentation",
"hidden": true
},
{
"type": "refactor",
"section": "Code Refactoring",
"hidden": true
},
{
"type": "test",
"section": "Tests",
"hidden": true
},
{
"type": "ci",
"section": "Continuous Integration",
"hidden": true
}
],
"packages": {
".": {}
}
}

0 comments on commit 80f6989

Please sign in to comment.