Skip to content

Commit

Permalink
fix: increase event timeout (#118)
Browse files Browse the repository at this point in the history
Issue #, if available: Still seeing failures:
https://github.com/runfinch/finch/actions/runs/7820846068/job/21371714848?pr=795#step:10:6233

*Description of changes:*
- Double event timeout

*Testing done:*
- The same tests currently runs twice, with different arguments.
Sometimes, one of these times succeeds in just under 15 seconds, so
increasing the timeout to over 15s may make the test more reliable
-
https://github.com/runfinch/finch/actions/runs/7820846068/job/21371714848?pr=795#step:10:6184



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Justin Alvarez <[email protected]>
  • Loading branch information
pendo324 authored Feb 12, 2024
1 parent d5a29d5 commit 22ca9e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func Logs(o *option.Option) {
command.Run(o, "exec", testContainerName, "sh", "-c", fmt.Sprintf("echo %s >> /proc/1/fd/1", newLog))
// allow propagation time
gomega.Eventually(strings.TrimSpace(string(session.Out.Contents()))).
WithTimeout(15 * time.Second).
WithTimeout(30 * time.Second).
WithPolling(1 * time.Second).
Should(gomega.Equal(newLog))
})
Expand Down

0 comments on commit 22ca9e4

Please sign in to comment.