Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Soul Wars Plugin to v1.2.0 #7010

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Updated Soul Wars Plugin to v1.2.0 #7010

merged 2 commits into from
Nov 20, 2024

Conversation

Lucidare
Copy link
Contributor

Added enter/leave game notifications
Updated README.md
Updated version to v1.2

@runelite-github-app
Copy link

runelite-github-app bot commented Nov 20, 2024 •
edited
Loading

soul-wars: 024def2e75505075f42bd2bea94d7694840a5767...42fc6d6d718442cae905729d7b8d21bb0993ba6e

tylerwgrass
tylerwgrass previously approved these changes Nov 20, 2024
View reviewed changes
@iProdigy
Copy link
Member

you could retain the keyName for shouldNotifyActivity as shouldNotify so people who set it to false won't have it set to true after this update

@Lucidare
Copy link
Contributor Author

you could retain the keyName for shouldNotifyActivity as shouldNotify so people who set it to false won't have it set to true after this update

Good call, updated

@tylerwgrass tylerwgrass merged commit 75de1be into runelite:master Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerwgrass tylerwgrass tylerwgrass approved these changes

@iProdigy iProdigy iProdigy approved these changes

Assignees
No one assigned
Labels
plugin change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lucidare @iProdigy @tylerwgrass