Streaming HTML search results #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To see if streaming works properly
TODOs: 1. Make "dump-decls" build by not running the "test" test suite 2. Runtime dep "graphviz"
TODO: fix `<command line>: Could not find module ‘Exe’`
TODO: fix benchmark/BenchmarkWeb.hs
To resolve error in CI: ``` Configuring library for zlib-0.7.1.0.. cabal: Missing dependency on a foreign library: * Missing (or bad) C library: z ```
This reverts commit 041d165.
8cf55da didn't do the trick
This reverts commit e30623e.
TODO: figure out why the second run on failure produces no results
Hopefully fixes #7
unit-test: also test stream-based query function
And Server.HtmlStream.{mkStartEndElem, streamTagBalancedM}
…-graph into streaming
This reverts commit 5300b33.
And vice versa
Before, in case of failure, it printed out all edges in the graph. Instead just print the missing edges.
Possibly a bug in https://github.com/bgamari/html-parse. TODO: create minimal reproduction of issue (one of the `script` tags should suffice)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
yieldBalancedM(https://github.com/runeksvendsen/haskell-function-graph/pull/5/files#diff-d824a721de4304f9c78d40600aed08c8a9cb64c403bf0a204779367c0ef5bf38R129)SearchConfig(https://github.com/runeksvendsen/haskell-function-graph/pull/5/files#diff-7511b42f11f3132334d2cf2a9bed67de38e5f87065b3d5d152efef78ba5563a5R50)NoGraph(https://github.com/runeksvendsen/haskell-function-graph/pull/5/files#diff-16dae27ea4ae8c2eb2a66566521b48e03912507432c2262d7bfeab82226b54fdR78)<script src="https://unpkg.com...">