Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Trading #345

Draft
wants to merge 222 commits into
base: feature/player-trading
Choose a base branch
from
Draft

[DRAFT] Trading #345

wants to merge 222 commits into from

Conversation

nicknick-io
Copy link
Contributor

@nicknick-io nicknick-io commented Sep 29, 2021 •
edited
Loading

Todo

  • Ability to right-click a player and request to trade
  • Ability for target player to accept the trade request
  • Close the trading window for both players when one cancels the trade
  • Ability to add items to the trading window, remember stackable items...
  • Check if both players have accepted, and continue to next window.
  • Show the items in the last trading window
  • Check if the players has accepted the trade in window two
  • Exchange items

nicknick-io and others added 15 commits August 25, 2021 22:21
@nicknick-io
Started work on trading.
3383baf
@nicknick-io
Work in progress
5a0f6e6
@Promises
trading stuff
629d055
@nicknick-io
Merge pull request #1 from Promises/feature/trading
54c25f6
@nicknick-io
We are now able to add and remove stuff from the trading window..
4014a05
@nicknick-io
Added close handling.
a23908b
@nicknick-io
Item are now removed from a specific slot in both inventory and the a…
9a1a408 
…ctual trade widget.
@Tynarus
Working on engine import/pkg improvements to make content dev simpler
dcf93fc
@Tynarus
Improving engine/config package/import structure with an index.ts entry
eef4e7d
@Tynarus
Improving engine/net package/import structure with an index.ts entry
a9e04b7
@Tynarus
engine/util's turn for an index.ts file
2fbab21
@Tynarus
Adding more index file entries and cleaning up world.ts imports
0ec1dd4
@Tynarus
Adding world/config/index.ts and fixing more imports in world.ts
00075f7
@Tynarus
Lint fix
8c47db5
@nicknick-io
Merge github.com:runejs/server into feature/trading
6f60019
@nicknick-io nicknick-io changed the title Trading [Draft] Trading Sep 29, 2021
@nicknick-io nicknick-io changed the title [Draft] Trading [DRAFT] Trading Sep 29, 2021
@SchauweM SchauweM added enhancement Enhancement to an existing feature game engine Updates involving the main game engine or game logic new feature A new feature or request plugins Updates involving content plugins work in progress Work in progress labels Sep 29, 2021
Jameskmonger and others added 29 commits February 11, 2023 18:53
@Jameskmonger
refactor: typescript null fixes in action code
8dacc52
@Jameskmonger
refactor: null check fixes in plugins
c18549c
@Jameskmonger
refactor: null check fixes in engine/world
f327f14
@Jameskmonger
refactor: various null check fixes
982a5cd
@Jameskmonger
refactor: fix actor and player instance
1259e1f
@Jameskmonger
refactor: more null checks
fe58db1
@Jameskmonger
refactor: last plugin-based type issues
fdcfd6c
@Jameskmonger
refactor: fixing world typing issues
b788078
@Jameskmonger
refactor: fix null sockets
60a28fa
@Jameskmonger
refactor: fix ByteBuffer nullishness in GameServerConnection
ac0dad4
@Jameskmonger
refactor: mark translate___ServerConfig keys as | undefined
7d9300e
@Jameskmonger
build: ♻️ 👷 🔧
8392255 
Turn on `strictNullChecks`
@Jameskmonger
Merge branch 'develop' into strict-mode
8a30136
@Jameskmonger
build: also turn on strictBindCallApply
ae43b1f
@Jameskmonger
Merge branch 'strict-mode' of github.com:Jameskmonger/runejs-server i…
5fc798f 
…nto strict-mode
@Jameskmonger
some cr feedback
95a2d6d
@Jameskmonger
refactor: suppress @typescript-eslint/no-non-null-assertion warnings
66ea030
@Jameskmonger
refactor: playAnimation can be null
c60e9ae
@Jameskmonger
refactor: return undefined from queue.dequeue
0f7c507
@Jameskmonger
comments for null as unknown as Foo
0bffb5f
@Jameskmonger
update docs to reflect WorldInstance constructor
ac1b057
@Jameskmonger
refactor: instanceId no longer optional on findNearbyPlayers
95e96f0
@Katilith
Merge branch 'develop' into levelup-bug
6179136
@Katilith
Merge pull request runejs#391 from jameshallam93/levelup-bug
9b1d4a8 
fix: level up widget bug
@Katilith
Merge branch 'develop' into strict-mode
e6e66cf
@Promises
Merge pull request runejs#392 from Jameskmonger/strict-mode
bc1b899 
build: ♻️ 👷 🔧 turn on `strictNullChecks`
@SchauweM
Merge branch 'develop' into use-runejs-store
3f9fe62
@SchauweM
Merge pull request runejs#389 from Jameskmonger/use-runejs-store
3acbd35 
chore: use `@runejs/store` instead of `filestore` to remove canvas dependency
@nicknick-io
Merge branch 'runejs:develop' into feature/trading
8d1d0bb
@Jameskmonger Jameskmonger added the pre-tick PR's made before the tick based system was introduced label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancement to an existing feature game engine Updates involving the main game engine or game logic new feature A new feature or request plugins Updates involving content plugins pre-tick PR's made before the tick based system was introduced work in progress Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nicknick-io @gruckion @Jameskmonger @SchauweM @Promises @Tynarus @RedSparr0w @Katilith @jameshallam93