Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional reference job flags #140

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

b0tting
Copy link

@b0tting b0tting commented Sep 25, 2024

This request adds the missing four flags that are available when adding a reference job step in a Rundeck command. This should solve #127

I added a test that should validate the added flags and the earlier added reference project name. I tested the provider, but I could not get the included tests running. It could be that this test still fails, while the new flags function as expected.

@fdevans fdevans changed the base branch from master to job-ref-flags September 26, 2024 18:33
Copy link
Contributor

@fdevans fdevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merging to a local branch for testing, then will merge to Master and release if they work.

Thank you @b0tting

@fdevans fdevans merged commit d260efb into rundeck:job-ref-flags Sep 26, 2024
3 checks passed
@fdevans fdevans mentioned this pull request Sep 26, 2024
@fdevans fdevans added this to the 0.4.8 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants