0.4.8 - Collection of updates #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompotency had issues.
…ompotency had issues.
Add timeout and success_on_empty_node_filter to attributes set to the job based on job data (jobToResourceData function) Fix TestOchestrator_high_low and TestOchestrator_max_percent (wrong job name in the expected/actual test) Fix testAccJobOptions_secure_options (shouldn't expect an error, should just check that the right option on the job has been set)
Change JobCommand struct to correctly parse the plugins block from the XML job definition Add JobPlugins struct to parse LogFilterPlugins Change the job resource schema to include the log_filter_plugin attribute Change parsing of resource data into a plugin object to instantiate the command's plugins Add documentation about the plugins block Add example to the docs for the new log_filter_plugin attribute
Add script_url param to Command. Merging to a local branch for testing and potential merge for 0.4.8
Script url
Added optional referenced project name to external job step Merging to local branch to test and finalize for 0.4.8
Project name ref finalizes #129
Awesome! Merging to a local branch for testing and any needed updates.
Log filters implemented by #131 Tested and worked great.
Add support for importing jobs into the Terraform state Changed base and importing to test locally and provide any needed updates.
Import jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of Community Pull Requests that include the following functionality.
script_urlproject_nameinjobcommand type.