Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSE-812: Fix: not importing logs from azure #37

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

L2JE
Copy link
Contributor

@L2JE L2JE commented Oct 2, 2023

Ticket: https://pagerduty.atlassian.net/browse/RSE-740
Depends on: rundeck/rundeck#8583

Support the use of outputfilepath execution context variable to access log files in case the isRemoteFilePath variable is true, meaning is an imported execution.

@L2JE L2JE requested a review from ronaveva October 3, 2023 15:59
@L2JE L2JE added this to the 4.17.2 milestone Oct 17, 2023
Copy link

@ronaveva ronaveva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add javadoc to new method

@L2JE L2JE requested a review from ronaveva October 19, 2023 19:19
Copy link

@ronaveva ronaveva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L2JE
Copy link
Contributor Author

L2JE commented Oct 23, 2023

Waiting for core 4.17.2-rc1 to be released to set the correct dependency

@L2JE L2JE force-pushed the rse740-not-importing-logs-from-S3logstore branch from 12a7a20 to 9f680c9 Compare October 26, 2023 12:19
@L2JE L2JE merged commit ea6e082 into master Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants