Skip to content

Commit

Permalink
Merge pull request #614 from Corbe30/bugfix/yarn-tsc-getContainer
Browse files Browse the repository at this point in the history
fixed: reverted getContainer change
  • Loading branch information
sanchit3008 authored Oct 22, 2024
2 parents b441c81 + 94a091d commit 5f2da8e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/react/src/components/FilterOption/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ import React, { useCallback, useContext, useEffect } from "react";
import WorkbookContext from "../../context";
import SVGIcon from "../SVGIcon";

const FilterOptions: React.FC<{}> = () => {
const FilterOptions: React.FC<{ getContainer: () => HTMLDivElement }> = ({
getContainer,
}) => {
const { context, setContext, refs } = useContext(WorkbookContext);
const {
filterOptions,
Expand Down Expand Up @@ -75,7 +77,7 @@ const FilterOptions: React.FC<{}> = () => {
};
});
},
[filterOptions, refs.scrollbarX, refs.scrollbarY, setContext]
[filterOptions, getContainer, refs.scrollbarX, refs.scrollbarY, setContext]

Check warning on line 80 in packages/react/src/components/FilterOption/index.tsx

View workflow job for this annotation

GitHub Actions / test

React Hook useCallback has an unnecessary dependency: 'getContainer'. Either exclude it or remove the dependency array
);

const freezeType = frozen?.type;
Expand Down

0 comments on commit 5f2da8e

Please sign in to comment.