Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bug fixes and performance improvements #36

Merged
merged 2 commits into from
May 5, 2021
Merged

Minor bug fixes and performance improvements #36

merged 2 commits into from
May 5, 2021

Conversation

tdulcet
Copy link
Collaborator

@tdulcet tdulcet commented May 5, 2021 •
edited
Loading

  • Disables autocorrections when text is selected.
    • On Slack, pressing backspace with selected text would delete the whole paragraph for some reason.
  • Fixes race condition.
    • Waits for the all context menu items to be created before refreshing the menu.
  • Minor ESLint fixes.
  • Updated comments.
  • Improved performance.
    • Removed unnecessary code.
    • Shortened the context menu preview length. The new Proton UI in Firefox 89 seems to significantly shrink the maximum context menu width, so this accounts for that.
  • Added Chromium/Chrome to README.

The above changes that are applicable to rugk/awesome-emoji-picker#93 were backported in rugk/awesome-emoji-picker@78220fc.

@tdulcet tdulcet requested a review from rugk May 5, 2021 11:15
@tdulcet tdulcet added bug Something isn't working code quality Improving the code for the code's sake… site-issue A problem with/issue about a specific site labels May 5, 2021
rugk
rugk approved these changes May 5, 2021
View reviewed changes
src/content_scripts/autocorrect.js Show resolved Hide resolved
@rugk rugk merged commit 2f3c35b into main May 5, 2021
@rugk rugk deleted the minor-fixes branch May 5, 2021 15:00
@tdulcet tdulcet mentioned this pull request May 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rugk rugk rugk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working code quality Improving the code for the code's sake… site-issue A problem with/issue about a specific site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdulcet @rugk