ESLint and Biome fixes #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rugk
requested changes
Dec 18, 2024
| } | ||
|
|
||
| return count; | ||
| return Array.from(segmenter.segment(str.replaceAll("\u200D", ""))).length; |
There was a problem hiding this comment.
Suggested change
| return Array.from(segmenter.segment(str.replaceAll("\u200D", ""))).length; | |
| const STRING_JOINER_CHAR = "\u200D" | |
| return Array.from(segmenter.segment(str.replaceAll(STRING_JOINER_CHAR, ""))).length; |
Another example on how you can remove the explanatory comment above and explain the code… with code itself.
There was a problem hiding this comment.
See my comment in Unicodify: rugk/unicodify#96 (comment)
| @@ -125,6 +123,8 @@ export async function triggerOnSelect(emoji) { | |||
| if (closePopup) { | |||
| window.close(); | |||
| } | |||
| } else { | |||
| CommonMessages.showError("couldNotDoAction", true); | |||
There was a problem hiding this comment.
I am unsure, is couldNotDoAction really already defined?
There was a problem hiding this comment.
See above on lines 117-119. This is just switching the twisted if/else statements per the no-negated-condition ESLint rule. The Unicorn ESLint plugin includes an autofix for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeofoperator.windowwithglobalThis.Intl.Segmenter.RegExp.escapeif available.