Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/v1.86.0 into main #3925

Merged
merged 24 commits into from
Dec 10, 2024
Merged

chore(release): pull release/v1.86.0 into main #3925

merged 24 commits into from
Dec 10, 2024

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

yashasvibajpai and others added 21 commits November 20, 2024 03:28
* chore: update default case handling in facebook destinations

* fix: update default handling for some error codes
- used error_user_msg field as error message
- when no error is seen, handled error by stringifying
- update test-cases

---------

Co-authored-by: Sai Sankeerth <[email protected]>
…e there (#3910)

* fix: remove redundant ids and userIdentifier when gbraid or wbraid are there

* chore: address comment

* chore: fix sonar cloud issue

* chore: fix sonar cloud issue

* chore: decrease Cognitive Complexity from 17 to the 15

* chore: fix lint error

* chore: specify head commit hash for checkout temporarily

* chore: fix fetch depth

* chore: fix fetch depth to 0

* chore: reset commit sha

---------

Co-authored-by: Sai Kumar Battinoju <[email protected]>
achettyiitr
achettyiitr previously approved these changes Dec 9, 2024
@devops-github-rudderstack
Copy link
Contributor Author

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 98.86364% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.49%. Comparing base (275e971) to head (6a0f475).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
.../shopify/webhookTransformations/serverSideUtlis.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3925      +/-   ##
==========================================
+ Coverage   90.47%   90.49%   +0.01%     
==========================================
  Files         615      615              
  Lines       32320    32393      +73     
  Branches     7677     7706      +29     
==========================================
+ Hits        29242    29314      +72     
- Misses       2822     2823       +1     
  Partials      256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krishna2020
krishna2020 previously approved these changes Dec 10, 2024
utsabc
utsabc previously approved these changes Dec 10, 2024
@utsabc utsabc dismissed stale reviews from krishna2020 and themself via 31e422c December 10, 2024 10:36
utsabc
utsabc previously approved these changes Dec 10, 2024
ItsSudip
ItsSudip previously approved these changes Dec 10, 2024
shrouti1507
shrouti1507 previously approved these changes Dec 10, 2024
@utsabc utsabc dismissed stale reviews from shrouti1507, ItsSudip, and themself via 6a0f475 December 10, 2024 11:00
@utsabc utsabc merged commit 0965f30 into main Dec 10, 2024
31 checks passed
@utsabc utsabc deleted the release/v1.86.0 branch December 10, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.