Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve iterable network handler #3918

Merged

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Dec 6, 2024

What are the changes introduced in this PR?

Provide more structure to the an improved network handler for Iterable destination.

What is the related Linear task?

Resolves INT-2901

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sanpj2292 sanpj2292 requested review from sivashanmukh and a team as code owners December 6, 2024 14:35
@sanpj2292 sanpj2292 requested review from shrouti1507 and removed request for a team and sivashanmukh December 6, 2024 14:36
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (97d531f) to head (96ae92c).
Report is 1 commits behind head on fix.iterable-networkhandler.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           fix.iterable-networkhandler    #3918      +/-   ##
===============================================================
- Coverage                        90.49%   90.49%   -0.01%     
===============================================================
  Files                              619      619              
  Lines                            32440    32408      -32     
  Branches                          7701     7691      -10     
===============================================================
- Hits                             29358    29328      -30     
+ Misses                            2858     2824      -34     
- Partials                           224      256      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@shrouti1507 shrouti1507 merged commit 3789652 into fix.iterable-networkhandler Dec 7, 2024
23 of 24 checks passed
@shrouti1507 shrouti1507 deleted the chore.improve-iterable-nw-handler branch December 7, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants