Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard topsort destination #3913

Merged
merged 15 commits into from
Dec 13, 2024
Merged

Conversation

aanshi07
Copy link
Contributor

@aanshi07 aanshi07 commented Dec 4, 2024

What are the changes introduced in this PR?

Onboarded topsort destination

What is the related Linear task?

Resolves INT-2661

Doc: https://api.docs.topsort.com/api-reference/events/report-events

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aanshi07 aanshi07 requested a review from utsabc December 4, 2024 01:33
@aanshi07 aanshi07 self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 92.56757% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.50%. Comparing base (275e971) to head (e8ee4f3).
Report is 31 commits behind head on develop.

Files with missing lines Patch % Lines
src/v0/destinations/topsort/transform.js 89.23% 7 Missing ⚠️
src/v0/destinations/topsort/utils.js 89.28% 3 Missing ⚠️
src/v0/util/index.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3913      +/-   ##
===========================================
+ Coverage    90.47%   90.50%   +0.02%     
===========================================
  Files          615      620       +5     
  Lines        32320    32518     +198     
  Branches      7677     7710      +33     
===========================================
+ Hits         29242    29429     +187     
- Misses        2822     2865      +43     
+ Partials       256      224      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aanshi07 aanshi07 requested a review from sandeepdsvs December 11, 2024 05:42
aanshi07 and others added 5 commits December 11, 2024 14:15
- moved impressions and clicks logic into its own file
- moved purchase related logic into its own file
@devops-github-rudderstack
Copy link
Contributor

@aanshi07 aanshi07 marked this pull request as ready for review December 13, 2024 08:47
@aanshi07 aanshi07 requested review from a team and sivashanmukh as code owners December 13, 2024 08:47
@aanshi07 aanshi07 requested a review from krishna2020 December 13, 2024 08:47
Copy link
Contributor

@sandeepdsvs sandeepdsvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aanshi07 aanshi07 merged commit 227419f into develop Dec 13, 2024
27 checks passed
@aanshi07 aanshi07 deleted the feat.onboard_topsort_destination branch December 13, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants