-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for getting anonymousId by note attributes array #3893
feat: add support for getting anonymousId by note attributes array #3893
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3893/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3893 +/- ##
===========================================
- Coverage 90.47% 90.47% -0.01%
===========================================
Files 615 615
Lines 32329 32329
Branches 7681 7682 +1
===========================================
- Hits 29251 29250 -1
- Misses 2822 2823 +1
Partials 256 256 ☔ View full report in Codecov by Sentry. |
src/v1/sources/shopify/webhookTransformations/serverSideUtlis.js
Outdated
Show resolved
Hide resolved
src/v1/sources/shopify/webhookTransformations/serverSideUtlis.js
Outdated
Show resolved
Hide resolved
src/v1/sources/shopify/webhookTransformations/serverSideUtlis.js
Outdated
Show resolved
Hide resolved
b3f7140
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
What are the changes introduced in this PR?
Adding support for setting the
anonymousId
for the webhook events received from Shopify Pixel App, using thenote_attributes
array property which is populated with the following data from the script loaded onto the Shopify store.This value of
anonymousId
is from the cookies stored by Shopify on the store, which is essentially same as the value ofclientId
from the events received from the Web Pixel loaded onto the store.What is the related Linear task?
Resolves INT-2943
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
This
getAnonymousIdFromAttributes
function ensures that an anonymous ID is either retrieved from the event's note_attributes or generated based on the cart token if necessary.Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.