Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for getting anonymousId by note attributes array #3893

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Nov 19, 2024

What are the changes introduced in this PR?

Adding support for setting the anonymousId for the webhook events received from Shopify Pixel App, using the note_attributes array property which is populated with the following data from the script loaded onto the Shopify store.
This value of anonymousId is from the cookies stored by Shopify on the store, which is essentially same as the value of clientId from the events received from the Web Pixel loaded onto the store.

What is the related Linear task?

Resolves INT-2943

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

This getAnonymousIdFromAttributes function ensures that an anonymous ID is either retrieved from the event's note_attributes or generated based on the cart token if necessary.

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.47%. Comparing base (70fa123) to head (b3f7140).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
.../shopify/webhookTransformations/serverSideUtlis.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3893      +/-   ##
===========================================
- Coverage    90.47%   90.47%   -0.01%     
===========================================
  Files          615      615              
  Lines        32329    32329              
  Branches      7681     7682       +1     
===========================================
- Hits         29251    29250       -1     
- Misses        2822     2823       +1     
  Partials       256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krishna2020
krishna2020 previously approved these changes Dec 3, 2024
utsabc
utsabc previously approved these changes Dec 5, 2024
@yashasvibajpai yashasvibajpai dismissed stale reviews from krishna2020 and utsabc via b3f7140 December 5, 2024 19:04
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 New Major Issues (required ≤ 1)
17 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@krishna2020 krishna2020 merged commit d7f390c into develop Dec 6, 2024
26 of 27 checks passed
@krishna2020 krishna2020 deleted the feat.id.stitching.changes.shopify.pixel.app branch December 6, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants