Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle subaccount case in gaec #3876

Closed
wants to merge 2 commits into from
Closed

fix: handle subaccount case in gaec #3876

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db5669b
fix: handle subaccount case in gaec
Nov 13, 2024
4c674df
fix: comments addressed
Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/v0/destinations/google_adwords_enhanced_conversions/transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ const responseBuilder = async (metadata, message, { Config }, payload) => {
let { customerId, loginCustomerId } = Config;
const { configData } = Config;

let configDetails = {};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why let --> you are not updating the variable twice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

earlier was reassigning it so used let, now using ternary condition and const

if (isDefinedAndNotNull(configData)) {
const configDetails = JSON.parse(configData);
configDetails = JSON.parse(configData);
customerId = configDetails.customerId;
if (isDefined(configDetails.loginCustomerId)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code piece is not needed

loginCustomerId = configDetails.loginCustomerId;
Expand All @@ -70,6 +71,7 @@ const responseBuilder = async (metadata, message, { Config }, payload) => {
'developer-token': getValueFromMessage(metadata, 'secret.developer_token'),
};
response.params = { event, customerId: filteredCustomerId };

if (subAccount) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here add additional condition to execute this logic only if !isDefined(configDetails.loginCustomerId)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

if (!loginCustomerId) {
throw new ConfigurationError(`loginCustomerId is required as subAccount is true.`);
Expand All @@ -84,7 +86,9 @@ const responseBuilder = async (metadata, message, { Config }, payload) => {
response.headers['login-customer-id'] = filteredLoginCustomerId;
}

if (loginCustomerId) {
// isDefined and non empty loginCustomerId
if (isDefined(configDetails.loginCustomerId) && configDetails.loginCustomerId) {
loginCustomerId = configDetails.loginCustomerId;
const filteredLoginCustomerId = removeHyphens(loginCustomerId);
response.headers['login-customer-id'] = filteredLoginCustomerId;
}
Expand Down
Loading
Loading