Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support to eu/us2 datacenter for gainsight px destination #3871

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

manish339k
Copy link
Contributor

What are the changes introduced in this PR?

Extended datacenter support to eu/us2 region, apart from us.

What is the related Linear task?

Resolves INT-2845

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@manish339k manish339k requested a review from a team as a code owner November 12, 2024 03:53
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (b5baa75) to head (b13f28c).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3871      +/-   ##
===========================================
+ Coverage    89.02%   89.05%   +0.03%     
===========================================
  Files          610      610              
  Lines        32959    32995      +36     
  Branches      7789     7803      +14     
===========================================
+ Hits         29341    29383      +42     
+ Misses        3305     3299       -6     
  Partials       313      313              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manish339k manish339k merged commit 12ac3de into develop Nov 15, 2024
26 checks passed
@manish339k manish339k deleted the feat.gainsight.px.datacenter branch November 15, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants