Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pinterest_tag single product events with new mapping #3858

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Nov 7, 2024

What are the changes introduced in this PR?

We are adding support for new fields for single product events for pinterest_tag.

What is the related Linear task?

Resolves INT-2861

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@ItsSudip ItsSudip requested review from a team and sivashanmukh as code owners November 7, 2024 09:58
@ItsSudip ItsSudip requested review from sanpj2292 and utsabc November 7, 2024 09:58
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44%. Comparing base (e90d2ad) to head (aeb291b).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3858      +/-   ##
===========================================
+ Coverage    89.05%   90.44%   +1.38%     
===========================================
  Files          618      610       -8     
  Lines        33071    32133     -938     
  Branches      7814     7646     -168     
===========================================
- Hits         29452    29063     -389     
+ Misses        3336     2846     -490     
+ Partials       283      224      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ItsSudip ItsSudip changed the base branch from main to develop November 12, 2024 08:00
@ItsSudip ItsSudip merged commit 8520278 into develop Nov 18, 2024
26 checks passed
@ItsSudip ItsSudip deleted the fix.pinterestTag_typecasting branch November 18, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants