Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gaec migration #3855

Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat: gaec migration #3855

merged 1 commit into from
Nov 6, 2024

Conversation

aashishmalik
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (64583d0) to head (7ee1dd8).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3855   +/-   ##
========================================
  Coverage    89.01%   89.02%           
========================================
  Files          609      609           
  Lines        32904    32917   +13     
  Branches      7772     7778    +6     
========================================
+ Hits         29291    29304   +13     
- Misses        3300     3330   +30     
+ Partials       313      283   -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashishmalik aashishmalik force-pushed the feat.gaec-enchacements branch from f788f38 to 7ee1dd8 Compare November 5, 2024 21:16
@devops-github-rudderstack
Copy link
Contributor

Copy link

sonarqubecloud bot commented Nov 5, 2024

@aashishmalik aashishmalik marked this pull request as ready for review November 5, 2024 21:29
@aashishmalik aashishmalik requested review from a team and sivashanmukh as code owners November 5, 2024 21:29
@aashishmalik aashishmalik merged commit 7a26459 into develop Nov 6, 2024
26 checks passed
@aashishmalik aashishmalik deleted the feat.gaec-enchacements branch November 6, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants