Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsafe property getting set via set value library #3853

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Nov 5, 2024

What are the changes introduced in this PR?

set-value is a library we use to set a little deep nested keys are to be set into the transformed payload.
Currently when we try and set constructor.prototype.xxxx into the transformed payload using set-value package, there is an error being thrown saying Cannot set unsafe key: "constructor"

With the new library(we have implemented), we would just put the key as is.
For example

const { setValue: set } = require('@rudderstack/integrations-lib');
...
// Scenario: reserved keywords
set('constructor.prototype.xxxx', {}, 'value'); // { 'constructor.prototype.xxxx': 'value' }
// Scenario: not using reserved keywords
set('a.b.c', {}, 'value'); // { 'a': { 'b': { 'c': 'value' } } }
...

What is the related Linear task?

Resolves INT-2846

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sanpj2292 sanpj2292 self-assigned this Nov 5, 2024
@sanpj2292 sanpj2292 requested review from a team and sivashanmukh as code owners November 5, 2024 12:59
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (bbd31a1) to head (0723415).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3853      +/-   ##
===========================================
- Coverage    89.02%   89.01%   -0.02%     
===========================================
  Files          610      610              
  Lines        32918    32937      +19     
  Branches      7779     7777       -2     
===========================================
+ Hits         29305    29318      +13     
- Misses        3330     3336       +6     
  Partials       283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

@sanpj2292 sanpj2292 requested a review from utsabc November 7, 2024 07:26
Copy link

sonarqubecloud bot commented Nov 7, 2024

@sanpj2292 sanpj2292 merged commit 80d7b41 into develop Nov 8, 2024
26 checks passed
@sanpj2292 sanpj2292 deleted the fix.ga4-unsafe-set-value branch November 8, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants