Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shopify): seperate pixel server side events logic from legacy tracker implementation #3849

Merged
merged 13 commits into from
Nov 15, 2024

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Nov 4, 2024

What are the changes introduced in this PR?

In order to offer a different way of how event properties are now totally conformant to the RudderStack Ecom Spec, and also support a shopifyDetails object inside context, on lines of how events from web pixel have been structured, the events from the new RudderStack Pixel App go through the destination transformations introduced in this PR.

What is the related Linear task?

Resolves INT-2835

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
These are introduced to separate pixel server side events logic from legacy tracker implementation, to facilitate more granular control over the server side events from the new RudderStack Pixel app on shopify.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

No existing change to the legacy tracker based app's destination transformation logic.

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

None

Any technical or performance related pointers to consider with the change?

Some code duplication may occur to keep the transformed event same as earlier apart from 2 differences, in context and event properties as mentioned in the description.

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai self-assigned this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 98.50746% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.47%. Comparing base (64583d0) to head (9fec46e).
Report is 53 commits behind head on develop.

Files with missing lines Patch % Lines
...pify/webhookTransformations/serverSideTransform.js 97.80% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3849      +/-   ##
===========================================
+ Coverage    89.01%   90.47%   +1.45%     
===========================================
  Files          609      612       +3     
  Lines        32904    32247     -657     
  Branches      7772     7669     -103     
===========================================
- Hits         29291    29175     -116     
+ Misses        3300     2848     -452     
+ Partials       313      224      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

@yashasvibajpai yashasvibajpai changed the title chore: initial commit, adding transformation and utils chore (shopify): seperate pixel server side events logic from legacy tracker implementation Nov 6, 2024
@yashasvibajpai yashasvibajpai changed the title chore (shopify): seperate pixel server side events logic from legacy tracker implementation chore(shopify): seperate pixel server side events logic from legacy tracker implementation Nov 6, 2024
@yashasvibajpai yashasvibajpai marked this pull request as ready for review November 6, 2024 06:06
@yashasvibajpai yashasvibajpai requested review from a team and sivashanmukh as code owners November 6, 2024 06:06
krishna2020
krishna2020 previously approved these changes Nov 15, 2024
@yashasvibajpai yashasvibajpai merged commit c43f0bd into develop Nov 15, 2024
26 checks passed
@yashasvibajpai yashasvibajpai deleted the feat.shopify.pixelapp.server.events.refac branch November 15, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants