Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for identity stitching for shopify pixel flow #3818

Merged
merged 14 commits into from
Oct 24, 2024

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Oct 20, 2024

What are the changes introduced in this PR?

Using clientId from pixel events, to be used as anonymousId for events in server and pixel both, and mapped to the cartToken in redis for identity stitching.

What is the related Linear task?

Resolves INT-2728

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai self-assigned this Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.01%. Comparing base (31a963f) to head (7a8ffcf).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/v1/sources/shopify/pixelTransform.js 96.42% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3818   +/-   ##
========================================
  Coverage    89.00%   89.01%           
========================================
  Files          609      609           
  Lines        32872    32901   +29     
  Branches      7765     7768    +3     
========================================
+ Hits         29259    29287   +28     
- Misses        3300     3331   +31     
+ Partials       313      283   -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

@yashasvibajpai yashasvibajpai marked this pull request as ready for review October 22, 2024 11:31
@yashasvibajpai yashasvibajpai requested review from a team and sivashanmukh as code owners October 22, 2024 11:31
@yashasvibajpai yashasvibajpai requested a review from a team as a code owner October 23, 2024 06:19
utsabc
utsabc previously approved these changes Oct 23, 2024
src/v1/sources/shopify/pixelTransform.js Outdated Show resolved Hide resolved
src/v1/sources/shopify/pixelTransform.js Outdated Show resolved Hide resolved
src/v1/sources/shopify/pixelTransform.js Outdated Show resolved Hide resolved
src/v1/sources/shopify/pixelTransform.js Outdated Show resolved Hide resolved
utsabc
utsabc previously approved these changes Oct 24, 2024
utsabc
utsabc previously approved these changes Oct 24, 2024
krishna2020
krishna2020 previously approved these changes Oct 24, 2024
@yashasvibajpai yashasvibajpai dismissed stale reviews from krishna2020 and utsabc via a618ed5 October 24, 2024 10:23
Copy link

@krishna2020 krishna2020 merged commit 3a09181 into develop Oct 24, 2024
25 of 26 checks passed
@krishna2020 krishna2020 deleted the feat.shopify.pixel.id.stitching branch October 24, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants