Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not allowing empty string or null values for mandatory fields in zoho #3800

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Oct 15, 2024

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT- 2772

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 requested a review from a team as a code owner October 15, 2024 13:38
@shrouti1507 shrouti1507 self-assigned this Oct 15, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.05%. Comparing base (65a9844) to head (aa2fe76).
Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
src/cdk/v2/destinations/zoho/utils.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3800      +/-   ##
===========================================
+ Coverage    88.94%   89.05%   +0.11%     
===========================================
  Files          599      608       +9     
  Lines        32574    32989     +415     
  Branches      7741     7809      +68     
===========================================
+ Hits         28972    29380     +408     
+ Misses        3325     3302      -23     
- Partials       277      307      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@shrouti1507 shrouti1507 merged commit fcd8d99 into develop Oct 18, 2024
26 of 31 checks passed
@shrouti1507 shrouti1507 deleted the fix.zoho branch October 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants