Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard tune destination #3795

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Conversation

aanshi07
Copy link
Contributor

@aanshi07 aanshi07 commented Oct 14, 2024

What are the changes introduced in this PR?

Onboarded Tune destination

What is the related Linear task?

Resolves INT-282

Research Doc: https://www.notion.so/rudderstacks/Tune-0ae922ff65be4915897e437ac25c311c#b05d3640f14b4d4a84b176c922a9bc92

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aanshi07 aanshi07 requested review from a team and sivashanmukh as code owners October 14, 2024 06:04
@aanshi07 aanshi07 self-assigned this Oct 14, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (8f53316) to head (dad2d3c).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3795      +/-   ##
===========================================
- Coverage    89.06%   89.00%   -0.07%     
===========================================
  Files          608      608              
  Lines        32987    32849     -138     
  Branches      7807     7763      -44     
===========================================
- Hits         29379    29236     -143     
+ Misses        3331     3330       -1     
- Partials       277      283       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aanshi07 aanshi07 requested a review from utsabc October 14, 2024 06:30
yashasvibajpai
yashasvibajpai previously approved these changes Oct 14, 2024
yashasvibajpai
yashasvibajpai previously approved these changes Oct 15, 2024
@utsabc
Copy link
Member

utsabc commented Oct 17, 2024

Please fill up the description of the PR

src/v0/destinations/tune/transform.test.js Outdated Show resolved Hide resolved
src/v0/destinations/tune/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/tune/transform.js Show resolved Hide resolved
src/v0/destinations/tune/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/tune/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/tune/transform.js Outdated Show resolved Hide resolved
@utsabc
Copy link
Member

utsabc commented Oct 21, 2024

Add some router test cases as well

utsabc
utsabc previously approved these changes Oct 22, 2024
Copy link

@aanshi07 aanshi07 merged commit 741f0c6 into develop Oct 22, 2024
26 checks passed
@aanshi07 aanshi07 deleted the feat.onboard_tune_destination branch October 22, 2024 10:04
sanpj2292 pushed a commit that referenced this pull request Nov 5, 2024
* feat: onboard tune destination

* chore: test cases added

* chore: file name updated

* chore: import fix

* chore: updated mappings

* chore: updated transform.js

* chore: updated test cases

* chore: small fix

* chore: router test cases added

* chore: minor fix

---------

Co-authored-by: Sai Sankeerth <[email protected]>
sanpj2292 pushed a commit that referenced this pull request Nov 5, 2024
* feat: onboard tune destination

* chore: test cases added

* chore: file name updated

* chore: import fix

* chore: updated mappings

* chore: updated transform.js

* chore: updated test cases

* chore: small fix

* chore: router test cases added

* chore: minor fix

---------

Co-authored-by: Sai Sankeerth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants