fix: salesforce v2 refactor

[shrouti1507]

What are the changes introduced in this PR?

salesforceResponseHandler to re-visit using switch case instead of multiple if-else statements

To have single logic of to infer from event for OAUTH or LEGACY implementation - #2873 (comment)

What is the related Linear task?

Resolves INT-1129

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review

---

Developer checklist

• My code follows the style guidelines of this project

• No breaking changes are being introduced.

• All related docs linked with the PR?

• All changes manually tested?

• Any documentation changes needed with this change?

• Is the PR limited to 10 file changes?

• Is the PR limited to one linear task?

• Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

• Is the type of change in the PR title appropriate as per the changes?

• Verified that there are no credentials or confidential data exposed with the changes.

[codecov]

Codecov Report

Attention: Patch coverage is 84.61538% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (78c14b8) to head (80bea09).
Report is 38 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/v0/destinations/salesforce/utils.js	81.39%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3773      +/-   ##
===========================================
- Coverage    88.98%   88.97%   -0.02%     
===========================================
  Files          607      607              
  Lines        32800    32831      +31     
  Branches      7753     7759       +6     
===========================================
+ Hits         29188    29212      +24     
- Misses        3329     3336       +7     
  Partials       283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[koladilip]

Add description to PR

[devops-github-rudderstack]

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3773/test-report.html

[sanpj2292]

I feel we can rewrite the function in a simpler way like below

const handleAuthError = (
  errorCode,
  authKey,
  authorizationFlow,
  sourceMessage,
  destResponse,
  status,
) => {
  if (errorCode === 'INVALID_SESSION_ID') {
    let authErrCategory = '';
    if (authorizationFlow === OAUTH) {
      authErrCategory = getAuthErrCategoryFromStCode(status);
    } else {
      ACCESS_TOKEN_CACHE.del(authKey);
    }
    throw new RetryableError(
      `${DESTINATION} Request Failed - due to "INVALID_SESSION_ID", (${authErrCategory}) ${sourceMessage}`,
      500,
      destResponse,
      authErrCategory,
    );
  }

  throw new AbortedError(
    `${DESTINATION} Request Failed: "${status}" due to "${getErrorMessage(destResponse.response)}", (Aborted) ${sourceMessage}`,
    400,
    destResponse,
  );
};

[sonarqubecloud]

Quality Gate passed

Issues
17 New issues
1 Accepted issue

Measures
0 Security Hotspots
92.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[shrouti1507]

we are handling this in #3824