Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reuse ga4 network handler for ga4v2 #3768

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Sep 30, 2024

What are the changes introduced in this PR?

Add network handler for ga4 v2, reusing the existing ga4 network handler

What is the related Linear task?

Resolves INT-2725

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (4c0c681) to head (1f1727b).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3768      +/-   ##
===========================================
+ Coverage    88.89%   88.92%   +0.02%     
===========================================
  Files          600      600              
  Lines        32658    32623      -35     
  Branches      7757     7750       -7     
===========================================
- Hits         29032    29010      -22     
- Misses        3318     3336      +18     
+ Partials       308      277      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@yashasvibajpai yashasvibajpai merged commit 08cfdb9 into develop Sep 30, 2024
26 checks passed
@yashasvibajpai yashasvibajpai deleted the chore.ga4.v2.nw.handler branch September 30, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants