Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow users context traits and underscore divide numbers configuration #3752

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Sep 23, 2024

What are the changes introduced in this PR?

  • Playtomic feedback:
    • allowUsersContextTraits when set to false, if context.traits.* is present, it will be added only as context_traits_*.
    • underscoreDivideNumbers when set to false, if a column has a format like "*v3*", it will be formatted to "*v3*".
  • We need to populate those fields so that the older destinations behave similarly.

What is the related Linear task?

  • Resolves PIPE-1262.
  • Resolves PIPE-1413.

Developer checklist

  • My code follows the style guidelines of this project
  • No breaking changes are being introduced.
  • All related docs linked with the PR?
  • All changes manually tested?
  • Any documentation changes needed with this change?
  • Is the PR limited to 10 file changes?
  • Is the PR limited to one linear task?
  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?
  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

@achettyiitr achettyiitr changed the base branch from develop to main September 23, 2024 14:24
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (d70ac5d) to head (3363156).
Report is 3 commits behind head on hotfix/24092024.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           hotfix/24092024    #3752      +/-   ##
===================================================
+ Coverage            88.69%   88.86%   +0.16%     
===================================================
  Files                  594      595       +1     
  Lines                32413    32425      +12     
  Branches              7727     7711      -16     
===================================================
+ Hits                 28750    28815      +65     
+ Misses                3342     3333       -9     
+ Partials               321      277      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@achettyiitr achettyiitr merged commit 386d2ab into hotfix/24092024 Sep 24, 2024
30 checks passed
@achettyiitr achettyiitr deleted the fix.context-traits-underscore-divide branch September 24, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants