Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snowpipe streaming #3740

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: snowpipe streaming #3740

merged 1 commit into from
Oct 22, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Sep 17, 2024

What are the changes introduced in this PR?

  • A new integration for Snowpipe Streaming has been added, leveraging the existing Snowflake integration due to their similarity.

Developer checklist

  • My code follows the style guidelines of this project
  • No breaking changes are being introduced.
  • All related docs linked with the PR?
  • All changes manually tested?
  • Any documentation changes needed with this change?
  • Is the PR limited to 10 file changes?
  • Is the PR limited to one linear task?
  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?
  • Verified that there are no credentials or confidential data exposed with the changes.

@achettyiitr achettyiitr requested a review from a team as a code owner September 17, 2024 22:32
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (78c14b8) to head (8aa2f01).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3740      +/-   ##
===========================================
- Coverage    88.98%   88.98%   -0.01%     
===========================================
  Files          607      608       +1     
  Lines        32800    32803       +3     
  Branches      7753     7755       +2     
===========================================
+ Hits         29188    29190       +2     
+ Misses        3329     3300      -29     
- Partials       283      313      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch from a552215 to dc679b7 Compare September 22, 2024 11:35
@achettyiitr achettyiitr added the DO NOT MERGE Don't merge this PR without having discussion label Sep 22, 2024
@achettyiitr achettyiitr marked this pull request as draft September 23, 2024 19:33
@achettyiitr achettyiitr removed the DO NOT MERGE Don't merge this PR without having discussion label Sep 23, 2024
@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@achettyiitr achettyiitr marked this pull request as ready for review October 17, 2024 08:09
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch from 2663405 to 53686a4 Compare October 17, 2024 08:11
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch from 53686a4 to 7839ec0 Compare October 17, 2024 08:14
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch from 7839ec0 to 18b1f3f Compare October 19, 2024 05:15
@achettyiitr achettyiitr requested a review from a team as a code owner October 19, 2024 05:15
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch from 18b1f3f to 5595d4f Compare October 19, 2024 06:08
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch from 5595d4f to 8aa2f01 Compare October 19, 2024 06:10
Copy link

@achettyiitr achettyiitr requested review from sanpj2292 and a team October 22, 2024 05:47
@achettyiitr achettyiitr merged commit 21b1039 into develop Oct 22, 2024
23 checks passed
@achettyiitr achettyiitr deleted the feat.snowpipe-streaming branch October 22, 2024 05:49
sanpj2292 pushed a commit that referenced this pull request Nov 5, 2024
sanpj2292 pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants