Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: webhook v2 path variables support #3705

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Sep 3, 2024

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-2603

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@Gauravudia Gauravudia self-assigned this Sep 3, 2024
@Gauravudia Gauravudia requested review from a team and sivashanmukh as code owners September 3, 2024 09:46
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.62%. Comparing base (fa98d66) to head (322e9dd).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
src/cdk/v2/destinations/webhook_v2/utils.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3705      +/-   ##
===========================================
- Coverage    88.62%   88.62%   -0.01%     
===========================================
  Files          592      592              
  Lines        32198    32206       +8     
  Branches      7655     7657       +2     
===========================================
+ Hits         28537    28544       +7     
- Misses        3338     3369      +31     
+ Partials       323      293      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Copy link

sonarqubecloud bot commented Sep 6, 2024

@Gauravudia Gauravudia merged commit f7783d8 into develop Sep 6, 2024
24 checks passed
@Gauravudia Gauravudia deleted the feat.webhook.v2.path.variables branch September 6, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants