-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboard X(Twiiter) Audience #3696
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3696/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3696 +/- ##
===========================================
+ Coverage 88.62% 88.64% +0.01%
===========================================
Files 592 594 +2
Lines 32198 32348 +150
Branches 7655 7694 +39
===========================================
+ Hits 28537 28676 +139
- Misses 3338 3379 +41
+ Partials 323 293 -30 ☔ View full report in Codecov by Sentry. |
684e042
to
2504d7c
Compare
Quality Gate passedIssues Measures |
What are the changes introduced in this PR?
Onboarding new destination x(twitter) audience.
Write a brief explainer on your code changes.
Made new destination folder using nodeJs transformation.
Only
record
type of event is supported.All fields are optional
Batching is performed with max byte size as 4mb and max batch length as 2500
Docs: https://developer.x.com/en/docs/x-ads-api/audiences/api-reference/custom-audience-users#:~:text=Batch%20Requests,the%20initial%20request
What is the related Linear task?
Resolves INT-911
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.