Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle other error use-cases in reddit #3692

Merged

Conversation

yashasvibajpai
Copy link
Member

What are the changes introduced in this PR?

reddit 403 error handling

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai requested a review from a team as a code owner August 29, 2024 15:17
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (fix.reddit.nw.handler.release@ed4a1a6). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             fix.reddit.nw.handler.release    #3692   +/-   ##
================================================================
  Coverage                                 ?   88.60%           
================================================================
  Files                                    ?      591           
  Lines                                    ?    32111           
  Branches                                 ?     7643           
================================================================
  Hits                                     ?    28453           
  Misses                                   ?     3365           
  Partials                                 ?      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashasvibajpai yashasvibajpai requested review from sivashanmukh and a team as code owners August 29, 2024 15:32
@devops-github-rudderstack
Copy link
Contributor

Copy link

sonarqubecloud bot commented Sep 2, 2024

@yashasvibajpai yashasvibajpai changed the base branch from main to fix.reddit.nw.handler.release September 2, 2024 18:50
@yashasvibajpai yashasvibajpai merged commit 31d57e2 into fix.reddit.nw.handler.release Sep 2, 2024
30 of 31 checks passed
@yashasvibajpai yashasvibajpai deleted the chore.reddit.logger.for.403 branch September 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants