Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding a new condition for retrying the function creation in python transformation #3684

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

abhimanyubabbar
Copy link
Contributor

What are the changes introduced in this PR?

Neuroflow customer informed us that for one of there transformations, we are generating error codes when creating the function. The issue is that once a day the transformation connected to destination will receive a surge of traffic across all the UT pods and all of them tries to create the function in openfaas. This results in some of requests failing with statusCode 409 and events are dropped.

The fix recognises these failures and retries them so they are not dropped.

What is the related Linear task?

Resolves DAT-1510

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (ec0bffe) to head (6992035).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3684   +/-   ##
========================================
  Coverage    88.55%   88.55%           
========================================
  Files          585      585           
  Lines        31910    31916    +6     
  Branches      7613     7616    +3     
========================================
+ Hits         28258    28264    +6     
+ Misses        3359     3329   -30     
- Partials       293      323   +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhimanyubabbar abhimanyubabbar merged commit 9fb463e into develop Aug 29, 2024
26 checks passed
@abhimanyubabbar abhimanyubabbar deleted the fix/openfaas-fn-create-fn-race branch August 29, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants