Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: conflict fix from main to develop #3670

Merged
merged 12 commits into from
Aug 20, 2024
Merged

Conversation

sanpj2292
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Gauravudia and others added 12 commits August 12, 2024 11:23
…ing (#3308)

* feat: move hubspot to transformer proxy to enable partial batch handling

* chore: refactor code

* chore: add unit tests

* chore: refactor code

* chore: update error message

* fix: update network handler for legacy api

* chore: address comment

* chore: update failed tests

* fix: update network handler

* feat: add verification of single event

* chore: add test cases
fix: fixing clevertap bugsnag issue
* fix: fixing snapchat bugsnag issue

* fix: code review suggestion

Co-authored-by: Sankeerth <[email protected]>

---------

Co-authored-by: Sankeerth <[email protected]>
@sanpj2292 sanpj2292 requested review from a team and sivashanmukh as code owners August 20, 2024 12:12
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 94.49541% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (5471119) to head (ec0bffe).
Report is 21 commits behind head on develop.

Files Patch % Lines
src/v1/destinations/hs/networkHandler.ts 90.16% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3670   +/-   ##
========================================
  Coverage    88.54%   88.55%           
========================================
  Files          585      585           
  Lines        31860    31910   +50     
  Branches      7593     7613   +20     
========================================
+ Hits         28212    28258   +46     
- Misses        3326     3359   +33     
+ Partials       322      293   -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sanpj2292 sanpj2292 merged commit 899f8a0 into develop Aug 20, 2024
21 of 23 checks passed
@sanpj2292 sanpj2292 deleted the chore.conflict-main-develop branch August 20, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants