Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard smartly destination #3660

Merged
merged 19 commits into from
Aug 21, 2024

Conversation

aanshi07
Copy link
Contributor

@aanshi07 aanshi07 commented Aug 14, 2024

What are the changes introduced in this PR?

Onboarded new destination - Smartly

What is the related Linear task?

Resolves INT-1515

Smartly Doc for reference : https://support.smartly.io/hc/en-us/articles/4406049685788-S2S-integration-API-description#01H8HBXZF6WSKSYBW1C6NY8A88

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aanshi07 aanshi07 requested review from a team and sivashanmukh as code owners August 14, 2024 11:13
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.60%. Comparing base (6b1a23a) to head (a0cd469).
Report is 1 commits behind head on release/v1.76.0.

Files Patch % Lines
src/cdk/v2/destinations/smartly/utils.js 95.45% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v1.76.0    #3660      +/-   ##
===================================================
+ Coverage            88.59%   88.60%   +0.01%     
===================================================
  Files                  589      591       +2     
  Lines                32051    32101      +50     
  Branches              7631     7640       +9     
===================================================
+ Hits                 28395    28443      +48     
- Misses                3333     3365      +32     
+ Partials               323      293      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shrouti1507 shrouti1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we discuss to support event mapping in UI, and following code handling in transformer? Where is that part of code

shrouti1507
shrouti1507 previously approved these changes Aug 21, 2024
@anantjain45823
Copy link
Contributor

@CodeRabbit review

@aanshi07 aanshi07 changed the base branch from develop to release/v1.76.0 August 21, 2024 09:09
@aanshi07 aanshi07 merged commit 474a36e into release/v1.76.0 Aug 21, 2024
16 of 17 checks passed
@aanshi07 aanshi07 deleted the feat.onboard_smartly_destination branch August 21, 2024 09:15
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants