Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: webhook v2 #3651

Merged
merged 12 commits into from
Aug 29, 2024
Merged

feat: webhook v2 #3651

merged 12 commits into from
Aug 29, 2024

Conversation

Gauravudia
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-2479

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@Gauravudia Gauravudia self-assigned this Aug 12, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 98.55072% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.57%. Comparing base (ec0bffe) to head (7903ebb).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
src/cdk/v2/destinations/webhook_v2/utils.js 98.55% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3651      +/-   ##
===========================================
+ Coverage    88.55%   88.57%   +0.02%     
===========================================
  Files          585      586       +1     
  Lines        31910    31985      +75     
  Branches      7613     7627      +14     
===========================================
+ Hits         28258    28332      +74     
+ Misses        3359     3330      -29     
- Partials       293      323      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia marked this pull request as ready for review August 23, 2024 04:44
@Gauravudia Gauravudia requested review from a team and sivashanmukh as code owners August 23, 2024 04:44
utsabc
utsabc previously approved these changes Aug 28, 2024
@Gauravudia Gauravudia requested a review from ItsSudip August 28, 2024 11:17
ItsSudip
ItsSudip previously approved these changes Aug 29, 2024
Copy link

@Gauravudia Gauravudia requested review from ItsSudip and utsabc August 29, 2024 10:10
@Gauravudia Gauravudia merged commit e21ebd0 into develop Aug 29, 2024
25 of 26 checks passed
@Gauravudia Gauravudia deleted the feat.webhook.v2 branch August 29, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants