Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: klaviyo onboard unsubscribe profile support #3646

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Aug 11, 2024

What are the changes introduced in this PR?

Onboarding unsubscription support for profiles via identify and group calls with batching implemented in similar fashion as done for subscription
https://developers.klaviyo.com/en/reference/unsubscribe_profiles

What is the related Linear task?

Resolves INT-2484

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@anantjain45823 anantjain45823 self-assigned this Aug 11, 2024
@anantjain45823 anantjain45823 requested review from a team and sivashanmukh as code owners August 11, 2024 10:57
@anantjain45823
Copy link
Contributor Author

https://github.com/coderabbitai review

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (ee5d523) to head (f2ddc92).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/klaviyo/util.js 80.00% 4 Missing and 1 partial ⚠️
src/v0/destinations/klaviyo/transformV2.js 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3646      +/-   ##
===========================================
- Coverage    88.51%   88.51%   -0.01%     
===========================================
  Files          584      584              
  Lines        31760    31783      +23     
  Branches      7566     7579      +13     
===========================================
+ Hits         28112    28132      +20     
- Misses        3356     3358       +2     
- Partials       292      293       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yashasvibajpai
yashasvibajpai previously approved these changes Aug 16, 2024
Copy link

@sanpj2292 sanpj2292 self-requested a review August 19, 2024 06:35
@anantjain45823 anantjain45823 merged commit 474f2bd into develop Aug 19, 2024
16 of 17 checks passed
@anantjain45823 anantjain45823 deleted the feat.klaviyo_unsubscribe_profiles branch August 19, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants