Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source transformation integration test generation #3645

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Aug 9, 2024

What are the changes introduced in this PR?

Updated the generator script to:

  • Have an option to override receivedAt & request_ip from output of source transformation tests
  • Add \n for sources getting error responses
  • Generate batched responses correctly

What is the related Linear task?

Resolves INT-2353

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sanpj2292 sanpj2292 requested review from sivashanmukh and a team as code owners August 9, 2024 10:56
@sanpj2292 sanpj2292 self-assigned this Aug 9, 2024
@sanpj2292 sanpj2292 requested a review from lvrach August 9, 2024 10:56
@devops-github-rudderstack
Copy link
Contributor

Copy link

sonarqubecloud bot commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (8bbb7fb) to head (13f7e3b).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3645   +/-   ##
========================================
  Coverage    88.51%   88.51%           
========================================
  Files          584      584           
  Lines        31760    31760           
  Branches      7566     7566           
========================================
  Hits         28112    28112           
- Misses        3327     3356   +29     
+ Partials       321      292   -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292 sanpj2292 merged commit 23196ec into develop Aug 12, 2024
17 of 18 checks passed
@sanpj2292 sanpj2292 deleted the fix.src-test-gen branch August 12, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants