fix: add parent namespace and cluster information #3608
Conversation
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3608/test-report.html |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3608 +/- ##
========================================
Coverage 88.62% 88.63%
========================================
Files 592 592
Lines 32198 32206 +8
Branches 7655 7659 +4
========================================
+ Hits 28537 28545 +8
- Misses 3338 3368 +30
+ Partials 323 293 -30 ☔ View full report in Codecov by Sentry. |
|
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
…d image (#3682) * fix: login using docker creds on the node to allow to pull the desired image * fix: add steps to create regcred secret and then patch deployment with it * chore: fix the github action * chore: patch the service account in openfaas-fn ns to allow for pulling openfaas flask base images * chore: minor fixes
kanishkkatara
force-pushed
the
fix/add-ns-cluster-labels-openfaas
branch
from
2ae89d9 to
3d43771
Compare
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 29.1.1 to 29.2.5. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md) - [Commits](kulshekhar/ts-jest@v29.1.1...v29.2.5) --- updated-dependencies: - dependency-name: ts-jest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sankeerth <[email protected]>
src/util/customTransformer-faas.js
Outdated
| @@ -30,6 +32,8 @@ function generateFunctionName(userTransformation, libraryVersionIds, testMode, h | |||
| ids = ids.concat([hashSecret]); | |||
| } | |||
|
|
|||
| ids = ids.concat([PARENT_NAMESPACE, PARENT_CLUSTER]); | |||
There was a problem hiding this comment.
minor: add this line above hashsecret
|
kanishkkatara
dismissed stale reviews from Jayachand and themself
The base branch was changed.
devops-github-rudderstack
deleted the
fix/add-ns-cluster-labels-openfaas
branch
What are the changes introduced in this PR?
We have added 2 new labels to be added onto the openfaas-fn pods. This is done to identify the parent namespace and cluster which generates these fn pods. It will help us in situation where we are planning to run the multi-tenant cluster fn functions in enterprise us due to cost savings and hence bringing the bifurcation at the application level.
What is the related Linear task?
Fixes: DAT-1472
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.