Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard cordial source #3593

Merged
merged 9 commits into from
Jul 26, 2024
Merged

feat: onboard cordial source #3593

merged 9 commits into from
Jul 26, 2024

Conversation

aanshi07
Copy link
Contributor

@aanshi07 aanshi07 commented Jul 23, 2024

What are the changes introduced in this PR?

Onboarding new webhook source cordial

What is the related Linear task?

Resolves INT-2403

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aanshi07 aanshi07 self-assigned this Jul 23, 2024
@aanshi07 aanshi07 requested review from a team and sivashanmukh as code owners July 23, 2024 14:30
@aanshi07 aanshi07 requested review from utsabc and chandumlg July 23, 2024 14:30
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.19%. Comparing base (13dac30) to head (50a6fac).
Report is 36 commits behind head on develop.

Files Patch % Lines
src/v1/sources/cordial/transform.js 93.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3593      +/-   ##
===========================================
+ Coverage    88.11%   88.19%   +0.07%     
===========================================
  Files          584      592       +8     
  Lines        31496    31819     +323     
  Branches      7549     7602      +53     
===========================================
+ Hits         27754    28062     +308     
- Misses        3431     3446      +15     
  Partials       311      311              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/v0/sources/cordial/transform.js Outdated Show resolved Hide resolved
src/v0/sources/cordial/transform.js Outdated Show resolved Hide resolved
koladilip
koladilip previously approved these changes Jul 24, 2024
@aanshi07 aanshi07 requested a review from anantjain45823 July 24, 2024 11:28
src/v1/sources/cordial/transform.js Show resolved Hide resolved
src/v1/sources/cordial/mapping.json Outdated Show resolved Hide resolved
src/v1/sources/cordial/mapping.json Show resolved Hide resolved
src/v1/sources/cordial/transform.js Show resolved Hide resolved
src/v1/sources/cordial/transform.js Show resolved Hide resolved
src/v1/sources/cordial/transform.js Outdated Show resolved Hide resolved
src/v1/sources/cordial/transform.js Outdated Show resolved Hide resolved
test/integrations/sources/cordial/data.ts Outdated Show resolved Hide resolved
utsabc
utsabc previously approved these changes Jul 25, 2024
Copy link

@aanshi07 aanshi07 merged commit cdea69c into develop Jul 26, 2024
17 checks passed
@aanshi07 aanshi07 deleted the feat.cordial_source branch July 26, 2024 07:13
@Gauravudia Gauravudia restored the feat.cordial_source branch July 26, 2024 08:06
@devops-github-rudderstack devops-github-rudderstack deleted the feat.cordial_source branch October 27, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants