Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cordial #3587

Closed
wants to merge 14 commits into from
Closed

chore: cordial #3587

wants to merge 14 commits into from

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Jul 23, 2024

What are the changes introduced in this PR?

  • PR for dedicated deployment for cordial source and destination.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.19%. Comparing base (13dac30) to head (0caf95a).
Report is 110 commits behind head on develop.

Files Patch % Lines
src/v1/sources/cordial/transform.js 93.33% 2 Missing ⚠️
src/v0/destinations/klaviyo/transform.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3587      +/-   ##
===========================================
+ Coverage    88.11%   88.19%   +0.07%     
===========================================
  Files          584      592       +8     
  Lines        31496    31819     +323     
  Branches      7549     7604      +55     
===========================================
+ Hits         27754    28062     +308     
- Misses        3431     3446      +15     
  Partials       311      311              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia self-assigned this Jul 23, 2024
@Gauravudia Gauravudia added DO NOT MERGE Don't merge this PR without having discussion DO NOT TOUCH labels Jul 23, 2024
Copy link

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this PR without having discussion DO NOT TOUCH Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants