chore: cicd improvements #3585
chore: cicd improvements #3585
Conversation
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3585/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3585 +/- ##
===========================================
- Coverage 88.51% 88.51% -0.01%
===========================================
Files 584 584
Lines 31760 31783 +23
Branches 7566 7581 +15
===========================================
+ Hits 28112 28132 +20
+ Misses 3356 3329 -27
- Partials 292 322 +30 ☔ View full report in Codecov by Sentry. |
…ed files - chore: add json prettification on save in vscode settings
| - id: files | ||
| uses: Ana06/[email protected] | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Run format Checks | ||
| run: | | ||
| npx prettier ${{steps.files.outputs.added_modified}} --write |
There was a problem hiding this comment.
what's the time difference with only formatting the subset of files?
Is it possible to use GitHub action caching instead?
There was a problem hiding this comment.
The motivation of formatting subset of files is only to make sure the formatting/lint checks is being done on the files that are involved in the PR and not all files in repository(which was the case earlier)
Would like to understand why would we want to run tests in Docker environment. Because when there is any dependency upgrade we want to do, while a PR is raised with updation of docker base image the tests would run there & we would know if something feels off. If you feel, there is a scenario I'm missing, let me know |
* chore: update latest image sha * chore: add echo while setting a variable in run script * chore: update ut prod deployment workflow --------- Co-authored-by: Sai Sankeerth <[email protected]>
- introduce a flag to skip tests - modify artifact building workflow to know when to skip tests
- add capability to understand overall failure or just tests failure for notifying
|
What are the changes introduced in this PR?
CICD Improvements
latestis being built using merge commit SHA rather than the PR head commit SHADockerfile,package*.jsonWhat is the related Linear task?
Resolves INT-2419
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.