Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard new api for klaviyo 15-06-2024 #3574

Merged
merged 29 commits into from
Jul 31, 2024

Conversation

anantjain45823
Copy link
Contributor

What are the changes introduced in this PR?

This PR updates identify, track, screen and group API to the latest klaviyo API.
There are some new fields introduced like ip, _kx, longitude and latitude for profile object
And also there is schema changes for events api used for track call and group call

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-2250

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@anantjain45823 anantjain45823 requested review from a team and sivashanmukh as code owners July 19, 2024 04:59
@anantjain45823 anantjain45823 changed the title Feat.klaviyo api update 2 feat: onboard new api for klaviyo 15-06-2024 Jul 19, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 97.49104% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.48%. Comparing base (b0fc288) to head (364fadb).
Report is 3 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/klaviyo/transformV2.js 95.45% 5 Missing ⚠️
src/v0/destinations/klaviyo/util.js 97.89% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3574      +/-   ##
===========================================
+ Coverage    88.19%   88.48%   +0.28%     
===========================================
  Files          592      584       -8     
  Lines        31826    31741      -85     
  Branches      7607     7556      -51     
===========================================
+ Hits         28069    28086      +17     
+ Misses        3417     3360      -57     
+ Partials       340      295      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/v0/destinations/klaviyo/transformV2.js Outdated Show resolved Hide resolved
src/v0/destinations/klaviyo/transformV2.js Show resolved Hide resolved
src/v0/destinations/klaviyo/transformV2.js Outdated Show resolved Hide resolved
src/v0/destinations/klaviyo/util.js Outdated Show resolved Hide resolved
src/v0/destinations/klaviyo/util.js Outdated Show resolved Hide resolved
src/v0/destinations/klaviyo/util.js Show resolved Hide resolved
@anantjain45823 anantjain45823 requested a review from utsabc July 29, 2024 05:38
utsabc
utsabc previously approved these changes Jul 29, 2024
utsabc
utsabc previously approved these changes Jul 30, 2024
utsabc
utsabc previously approved these changes Jul 30, 2024
utsabc
utsabc previously approved these changes Jul 30, 2024
Gauravudia
Gauravudia previously approved these changes Jul 30, 2024
@anantjain45823 anantjain45823 dismissed stale reviews from Gauravudia and utsabc via 364fadb July 30, 2024 12:20
Copy link

@anantjain45823 anantjain45823 merged commit 44baab9 into develop Jul 31, 2024
17 checks passed
@anantjain45823 anantjain45823 deleted the feat.klaviyo_api_update_2 branch July 31, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants