Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sre 484 test out aggregating metrics in a worker thread with worker #3504

Conversation

dhawal1248
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@dhawal1248 dhawal1248 requested review from a team and sivashanmukh as code owners June 26, 2024 08:37
@dhawal1248 dhawal1248 added the DO NOT MERGE Don't merge this PR without having discussion label Jun 26, 2024
@dhawal1248 dhawal1248 changed the base branch from develop to feature/sre-484-test-out-aggregating-metrics-in-a-worker-thread-with-reset June 26, 2024 08:37
@dhawal1248 dhawal1248 changed the base branch from feature/sre-484-test-out-aggregating-metrics-in-a-worker-thread-with-reset to feature/sre-484-test-out-aggregating-metrics-in-a-worker-thread June 26, 2024 08:38
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (11c6f99) to head (40348ed).

Additional details and impacted files
@@                                         Coverage Diff                                         @@
##           feature/sre-484-test-out-aggregating-metrics-in-a-worker-thread    #3504      +/-   ##
===================================================================================================
+ Coverage                                                            87.76%   87.81%   +0.05%     
===================================================================================================
  Files                                                                  580      581       +1     
  Lines                                                                31365    31490     +125     
  Branches                                                              7470     7513      +43     
===================================================================================================
+ Hits                                                                 27527    27654     +127     
+ Misses                                                                3507     3503       -4     
- Partials                                                               331      333       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@dhawal1248 dhawal1248 closed this Jun 28, 2024
@dhawal1248 dhawal1248 deleted the feature/sre-484-test-out-aggregating-metrics-in-a-worker-thread-with-workerId branch June 28, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this PR without having discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants