Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull main into develop post release v1.69.1 #3502

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

anantjain45823 and others added 3 commits June 25, 2024 12:19
* feat: onboard user API for onesignal

* chore: add aliases from one signal intg object

* chore: add test cases

* chore: add test cases+1

* chore: add test cases+2

* chore: small fixes

* fix: lint errors

* fix: lint errors+1

* fix: lint errors+2

* chore: rename file

* chore: address comments
@devops-github-rudderstack
Copy link
Contributor Author

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 93.95973% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.10%. Comparing base (d963fe5) to head (bdcc878).
Report is 52 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/one_signal/util.js 89.83% 4 Missing and 2 partials ⚠️
src/v0/destinations/one_signal/transformV2.js 96.34% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3502      +/-   ##
===========================================
+ Coverage    88.02%   88.10%   +0.08%     
===========================================
  Files          570      580      +10     
  Lines        30795    31382     +587     
  Branches      7363     7486     +123     
===========================================
+ Hits         27107    27650     +543     
- Misses        3352     3420      +68     
+ Partials       336      312      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@krishna2020 krishna2020 merged commit 86cebc1 into develop Jun 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants